feat(stateful-set): allow configuring volumeClaimTemplates
#6382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkeil
force-pushed
the
feat/add-volume-claim-templates
branch
from
4f352bb to
3461368
Compare
iliapolo
changed the title
volumeClaimTemplates to kplus.StatefulSetvolumeClaimTemplates
iliapolo
added
backport-to-k8s-31/main
iliapolo
requested changes
Oct 16, 2025
| * | ||
| * This name should match the name of a volume mount in one of the containers. | ||
| */ | ||
| readonly name: string; |
Member
There was a problem hiding this comment.
Can we accept a Volume here instead? or a VolumeMount?
Contributor
Author
There was a problem hiding this comment.
I would let it as it is. You could still use the volume as a variable and use name: volume.name, I would not use it like this.
I could also think about something like:
VolumeClaimTemplatesSomeSuffix.fromVolume(volume, {
storage: Size.gibibytes(20),
accessModes: [kplus.PersistentVolumeAccessMode.READ_WRITE_ONCE_POD],
storageClassName: 'standard',
})But to be honest my absolute favourite would be something like:
new kplus.StatefulSet(chart, 'StatefulSet', {
containers: [
{
image: 'foobar',
portNumber: 80,
volumeMounts: [
{
volume: Volume.fromClaimTemplate({
name: "data",
storage: Size.gibibytes(20),
accessModes: [kplus.PersistentVolumeAccessMode.READ_WRITE_ONCE_POD],
storageClassName: 'standard',
}),
path: '/mnt/data',
},
],
},
],
})
Member
There was a problem hiding this comment.
I like Volume.fromClaimTemplate - probably a bit more involved to implement. Don't want to block on it so i'm approving this one. Feel free to add it in a subsequent PR though as an enhancement.
benkeil
force-pushed
the
feat/add-volume-claim-templates
branch
from
002c2aa to
c245003
Compare
Signed-off-by: Ben Keil <[email protected]>
Signed-off-by: Ben Keil <[email protected]>
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdk8s-team/cdk8s-plus/actions/runs/18441834896 ------ *Automatically created by projen via the "upgrade-dev-dependencies-k8s-33-main" workflow* Signed-off-by: Ben Keil <[email protected]>
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdk8s-team/cdk8s-plus/actions/runs/18460692313 ------ *Automatically created by projen via the "upgrade-dev-dependencies-k8s-33-main" workflow* Signed-off-by: Ben Keil <[email protected]>
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdk8s-team/cdk8s-plus/actions/runs/18470006676 ------ *Automatically created by projen via the "upgrade-configuration-k8s-33-main" workflow* Signed-off-by: Ben Keil <[email protected]>
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdk8s-team/cdk8s-plus/actions/runs/18491339374 ------ *Automatically created by projen via the "upgrade-dev-dependencies-k8s-33-main" workflow* Signed-off-by: Ben Keil <[email protected]>
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdk8s-team/cdk8s-plus/actions/runs/18500936773 ------ *Automatically created by projen via the "upgrade-configuration-k8s-33-main" workflow* Signed-off-by: Ben Keil <[email protected]>
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdk8s-team/cdk8s-plus/actions/runs/18523663856 ------ *Automatically created by projen via the "upgrade-dev-dependencies-k8s-33-main" workflow* Signed-off-by: Ben Keil <[email protected]>
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdk8s-team/cdk8s-plus/actions/runs/18528151867 ------ *Automatically created by projen via the "upgrade-compiler-dependencies-k8s-33-main" workflow* Signed-off-by: Ben Keil <[email protected]>
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdk8s-team/cdk8s-plus/actions/runs/18533358066 ------ *Automatically created by projen via the "upgrade-configuration-k8s-33-main" workflow* Signed-off-by: Ben Keil <[email protected]>
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdk8s-team/cdk8s-plus/actions/runs/18556119076 ------ *Automatically created by projen via the "upgrade-dev-dependencies-k8s-33-main" workflow* Signed-off-by: Ben Keil <[email protected]>
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdk8s-team/cdk8s-plus/actions/runs/18560556728 ------ *Automatically created by projen via the "upgrade-compiler-dependencies-k8s-33-main" workflow* Signed-off-by: Ben Keil <[email protected]>
Signed-off-by: Ben Keil <[email protected]>
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdk8s-team/cdk8s-plus/actions/runs/18565712529 ------ *Automatically created by projen via the "upgrade-configuration-k8s-33-main" workflow* Signed-off-by: Ben Keil <[email protected]>
Signed-off-by: Ben Keil <[email protected]>
benkeil
force-pushed
the
feat/add-volume-claim-templates
branch
from
c245003 to
e3bf4bb
Compare
iliapolo
approved these changes
Oct 16, 2025
Member
|
@benkeil looks good, you got some build failures though. |
Signed-off-by: Ben Keil <[email protected]>
Member
|
@benkeil new failures :) |
Signed-off-by: Ben Keil <[email protected]>
Signed-off-by: Ben Keil <[email protected]>
Contributor
Author
|
wait until it runs in my fork |
Contributor
Author
|
ok, build was successful |
cdk8s-automation
pushed a commit
that referenced
this pull request
Oct 17, 2025
Fixes cdk8s-team/cdk8s#2183 (cherry picked from commit d9ccf66)
cdk8s-automation
pushed a commit
that referenced
this pull request
Oct 17, 2025
Fixes cdk8s-team/cdk8s#2183 (cherry picked from commit d9ccf66)
cdk8s-automation
pushed a commit
that referenced
this pull request
Oct 17, 2025
Fixes cdk8s-team/cdk8s#2183 (cherry picked from commit d9ccf66)
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
cdk8s-automation
pushed a commit
that referenced
this pull request
Oct 17, 2025
Fixes cdk8s-team/cdk8s#2183 (cherry picked from commit d9ccf66)
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
…#6382) (#6419) # Backport This will backport the following commits from `k8s-33/main` to `k8s-31/main`: - [feat(stateful-set): allow configuring `volumeClaimTemplates` (#6382)](#6382) ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
…#6382) (#6420) # Backport This will backport the following commits from `k8s-33/main` to `k8s-32/main`: - [feat(stateful-set): allow configuring `volumeClaimTemplates` (#6382)](#6382) ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cdk8s-team/cdk8s#2183